Skip to content

Add support for adding vestigial implicits - #10156

Open
vaisest wants to merge 9 commits into
PathOfBuildingCommunity:devfrom
vaisest:add-vestigial
Open

Add support for adding vestigial implicits#10156
vaisest wants to merge 9 commits into
PathOfBuildingCommunity:devfrom
vaisest:add-vestigial

Conversation

@vaisest

@vaisest vaisest commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Fixes #9951

Description of the problem being solved:

This adds vestigial implicits to the add implicit menu. This was done by sort of exporting a list of mod id -> unique title it originates from. This allows us to know what modifiers are on which base types, and also allows us to show the source item.

The mods are sort of similar to the PoE2 handwraps in that they just have a prefix in the mod id, but there are a lot of things that aren't 1:1, and the biggest issue is that we don't have a perfect list of unique explicit mod ids. However, most of the were correct, and I manually corrected about 60 of them. I think most of them are correct now, and it should be better than poedb's list now

The filtering for what item you can add implicits to was done by assuming that no source flag in the item DB means that the item is in the core drop pool. To support this, I've added the source line to a lot of uniques, and have removed it from some. This was confirmed to be correct by comparing to Rasmus' unique data. Though it should be noted that I only focused on the vestigial base types, and haven't done this to other item types.

I think it would be a good idea to add an explicit Source: Drops anywhere line to all of these core pool items later.

Steps taken to verify a working solution:

  • Seems to work
  • Implicits are on correct types
  • Implicit sources are correct
  • Unique db filtering works

Link to a build that showcases this PR:

Before screenshot:

After screenshot:

Path{space}of{space}Building_2026-08-06_22-50-01 image image

Kaom's Command
Siege Helmet
League: Settlers of Kalguur
Source: Kingsmarch Shipping to normal{Ngakanu} or normal{Te Onui}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaisest

vaisest commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Another tiny problem I noticed is that some items have old variants which are matching here. For example The Snowblind Grace doesn't actually have the overcap mod anymore. I'm not sure if this is a problem or not. I can't find the matching mod id in any other unique, except for the perfect form which is always foulborn as far as I know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unique filter : core drop pool

1 participant