Add support for adding vestigial implicits - #10156
Open
vaisest wants to merge 9 commits into
Open
Conversation
vaisest
commented
Aug 7, 2026
| Kaom's Command | ||
| Siege Helmet | ||
| League: Settlers of Kalguur | ||
| Source: Kingsmarch Shipping to normal{Ngakanu} or normal{Te Onui} |
Contributor
Author
There was a problem hiding this comment.
Te Onui is not a typo
Contributor
Author
|
Another tiny problem I noticed is that some items have old variants which are matching here. For example The Snowblind Grace doesn't actually have the overcap mod anymore. I'm not sure if this is a problem or not. I can't find the matching mod id in any other unique, except for the perfect form which is always foulborn as far as I know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9951
Description of the problem being solved:
This adds vestigial implicits to the add implicit menu. This was done by sort of exporting a list of mod id -> unique title it originates from. This allows us to know what modifiers are on which base types, and also allows us to show the source item.
The mods are sort of similar to the PoE2 handwraps in that they just have a prefix in the mod id, but there are a lot of things that aren't 1:1, and the biggest issue is that we don't have a perfect list of unique explicit mod ids. However, most of the were correct, and I manually corrected about 60 of them. I think most of them are correct now, and it should be better than poedb's list now
The filtering for what item you can add implicits to was done by assuming that no source flag in the item DB means that the item is in the core drop pool. To support this, I've added the source line to a lot of uniques, and have removed it from some. This was confirmed to be correct by comparing to Rasmus' unique data. Though it should be noted that I only focused on the vestigial base types, and haven't done this to other item types.
I think it would be a good idea to add an explicit
Source: Drops anywhereline to all of these core pool items later.Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: